Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for in-memory outputs to output reuse #23422

Closed
wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 26, 2024

No description provided.

@fmeum fmeum requested a review from a team as a code owner August 26, 2024 14:04
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Aug 26, 2024
@fmeum fmeum requested review from tjgq and removed request for a team August 26, 2024 14:05
@fmeum fmeum requested review from a team and lberki as code owners August 28, 2024 14:21
@fmeum fmeum requested review from aranguyen and tjgq and removed request for a team August 28, 2024 14:21
@tjgq
Copy link
Contributor

tjgq commented Aug 28, 2024

Importing this one myself since internal changes are required.

@fmeum
Copy link
Collaborator Author

fmeum commented Aug 28, 2024

@bazel-io fork 7.4.0

@fmeum
Copy link
Collaborator Author

fmeum commented Aug 29, 2024

I resolved the merge conflict.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Aug 30, 2024
@fmeum fmeum deleted the reuse-inline-outputs branch August 30, 2024 12:55
fmeum added a commit to fmeum/bazel that referenced this pull request Sep 19, 2024
Closes bazelbuild#23422.

PiperOrigin-RevId: 669296792
Change-Id: If3a2519cbf57cc82f1f733900b93705065b37e63
@fmeum fmeum mentioned this pull request Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
Cherry-picks the following changes to implement output reuse:
* Deduplicate locally executed path mapped spawns (#22556)
* Fix local execution deduplication to work with optional outputs
(#23296)
* Force synchronous upload and reuse of possibly modified spawn outputs
(#23382)
* Add support for in-memory outputs to output reuse (#23422)

Fixes #23377
Fixes #23444
Fixes #23457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants